From 4b7d27057d1af58af6d4c6394fa4bde3602566a8 Mon Sep 17 00:00:00 2001
From: ulleo <ulleo.wang@gmail.com>
Date: Fri, 29 Aug 2025 17:18:57 +0800
Subject: [PATCH] fix(Terminology Configuration): Term name, synonyms cannot be
 repeated

---
 backend/apps/terminology/api/terminology.py  |  5 +--
 backend/apps/terminology/curd/terminology.py | 36 ++++++++++++++++++--
 backend/locales/en.json                      |  4 ++-
 backend/locales/zh-CN.json                   |  4 ++-
 4 files changed, 42 insertions(+), 7 deletions(-)

diff --git a/backend/apps/terminology/api/terminology.py b/backend/apps/terminology/api/terminology.py
index edb0df99..a7eda083 100644
--- a/backend/apps/terminology/api/terminology.py
+++ b/backend/apps/terminology/api/terminology.py
@@ -13,7 +13,8 @@ router = APIRouter(tags=["Terminology"], prefix="/system/terminology")
 @router.get("/page/{current_page}/{page_size}")
 async def pager(session: SessionDep, current_user: CurrentUser, current_page: int, page_size: int,
                 word: Optional[str] = Query(None, description="搜索术语(可选)")):
-    current_page, page_size, total_count, total_pages, _list = page_terminology(session, current_page, page_size, word, current_user.oid)
+    current_page, page_size, total_count, total_pages, _list = page_terminology(session, current_page, page_size, word,
+                                                                                current_user.oid)
 
     return {
         "current_page": current_page,
@@ -30,7 +31,7 @@ async def create_or_update(session: SessionDep, current_user: CurrentUser, trans
     if info.id:
         return update_terminology(session, info, oid, trans)
     else:
-        return create_terminology(session, info, oid)
+        return create_terminology(session, info, oid, trans)
 
 
 @router.delete("")
diff --git a/backend/apps/terminology/curd/terminology.py b/backend/apps/terminology/curd/terminology.py
index ab288b36..ff7f99d0 100644
--- a/backend/apps/terminology/curd/terminology.py
+++ b/backend/apps/terminology/curd/terminology.py
@@ -62,7 +62,6 @@ def page_terminology(session: SessionDep, current_page: int = 1, page_size: int
         if current_page > total_pages:
             current_page = 1
 
-
         # 步骤3：获取分页后的父节点ID
         paginated_parent_ids = (
             parent_ids_subquery
@@ -147,10 +146,22 @@ def page_terminology(session: SessionDep, current_page: int = 1, page_size: int
     return current_page, page_size, total_count, total_pages, _list
 
 
-def create_terminology(session: SessionDep, info: TerminologyInfo, oid: int):
+def create_terminology(session: SessionDep, info: TerminologyInfo, oid: int, trans: Trans):
     create_time = datetime.datetime.now()
     parent = Terminology(word=info.word, create_time=create_time, description=info.description, oid=oid)
 
+    words = [info.word]
+    for child in info.other_words:
+        if child in words:
+            raise Exception(trans("i18n_terminology.cannot_be_repeated"))
+        else:
+            words.append(child)
+
+    exists = session.query(
+        session.query(Terminology).filter(and_(Terminology.word.in_(words), Terminology.oid == oid)).exists()).scalar()
+    if exists:
+        raise Exception(trans("i18n_terminology.exists_in_db"))
+
     result = Terminology(**parent.model_dump())
 
     session.add(parent)
@@ -185,6 +196,26 @@ def update_terminology(session: SessionDep, info: TerminologyInfo, oid: int, tra
     if count == 0:
         raise Exception(trans('i18n_terminology.terminology_not_exists'))
 
+    words = [info.word]
+    for child in info.other_words:
+        if child in words:
+            raise Exception(trans("i18n_terminology.cannot_be_repeated"))
+        else:
+            words.append(child)
+
+    exists = session.query(
+        session.query(Terminology).filter(
+            Terminology.word.in_(words),
+            Terminology.oid == oid,
+            or_(
+                Terminology.pid != info.id,
+                and_(Terminology.pid.is_(None), Terminology.id != info.id)
+            ),
+            Terminology.id != info.id
+        ).exists()).scalar()
+    if exists:
+        raise Exception(trans("i18n_terminology.exists_in_db"))
+
     stmt = update(Terminology).where(and_(Terminology.id == info.id)).values(
         word=info.word,
         description=info.description,
@@ -211,7 +242,6 @@ def update_terminology(session: SessionDep, info: TerminologyInfo, oid: int, tra
     # embedding
     run_save_embeddings([info.id])
 
-
     return info.id
 
 
diff --git a/backend/locales/en.json b/backend/locales/en.json
index 429be3a4..1e72a99e 100644
--- a/backend/locales/en.json
+++ b/backend/locales/en.json
@@ -38,6 +38,8 @@
     "invalid_origin": "Domain verification failed [{origin}]"
   },
   "i18n_terminology": {
-    "terminology_not_exists": "Terminology does not exists"
+    "terminology_not_exists": "Terminology does not exists",
+    "cannot_be_repeated": "Term name, synonyms cannot be repeated",
+    "exists_in_db": "Term name, synonyms exists"
   }
 }
\ No newline at end of file
diff --git a/backend/locales/zh-CN.json b/backend/locales/zh-CN.json
index 70a8f171..bc846fb0 100644
--- a/backend/locales/zh-CN.json
+++ b/backend/locales/zh-CN.json
@@ -38,6 +38,8 @@
     "invalid_origin": "域名校验失败【{origin}】"
   },
   "i18n_terminology": {
-    "terminology_not_exists": "该术语不存在"
+    "terminology_not_exists": "该术语不存在",
+    "cannot_be_repeated": "术语名称，同义词不能重复",
+    "exists_in_db":  "术语名称，同义词已存在"
   }
 }
\ No newline at end of file