These tests exercise no production code path: each compares a package-level
constant, map or slice against a literal copy of its own declaration, so the
only way to make one fail is to edit the test in the same commit as the
source. That makes them a rename tax rather than a safety net.
Removed:
- cmd/multica: TestValidIssueStatuses (mirrors validIssueStatuses),
TestLoadConfigAllowNoAgentsIsOptIn (asserts the bool zero value that the
language already guarantees)
- internal/integrations/channel: TestCapability_BitsDistinct (iota block)
- internal/integrations/wecom: TestUnsupportedReceipt_DoesNotClaimTextOnly
- internal/daemon: TestAnnotationAvoidsPersistedRowGuards
- internal/metrics: TestBusinessMetricLabelsRejectHighCardinalityNames
- internal/service: TestChatQuickActionsPromptsNameNoLanguage
- internal/events: TestPublishNoSubscribersIsNoop (asserted nothing at all)
- pkg/agent: TestMcodeBlockedArgsKeepACPTransportStable,
TestQwenpawBlockedArgs, TestZeroclawBlockedArgs,
TestClaudeListModelsArgs_Pinned
- pkg/publicapi/v1: TestOperationLedgerPinsSharedScopes,
TestPluginExtensionsRejectUserCredentialsByContract,
TestOperationLedgerDeclaresAuditLifecycle
Behavioural tests over the same symbols are kept, including
TestCapability_Has, TestCapability_String, TestValidateIssueStatus and
TestOpenAPICoversCapabilityLedger — the last checks the operation ledger
against the embedded OpenAPI document rather than against itself.
Co-authored-by: Sol-Boy <[email protected]>
Co-authored-by: multica-agent <[email protected]>
* Fix MCode ACP session startup race
Co-authored-by: multica-agent <[email protected]>
* fix(agent): only trust transport signals for MCode startup exit
mcodeSessionStartupExited also matched "process exited" / "broken pipe"
anywhere in the error text. A still-running MCode reports session/new
failures as a JSON-RPC *acpRPCError, and session/new is the call that
launches mcpServers, so a real error such as `failed to start MCP
server "filesystem": process exited with code 1` was rewritten into
"MiniMax Code ACP exited before starting a session; ... upgrade
MiniMax Code". That branch returns a fixed string with no %v, so the
original error was dropped, not just relabelled, pointing the member
at the wrong subsystem.
Drop the text matching and keep the transport-level signals. Real
provider exits already arrive as errMcodeProcessExited via
closeAllPending, and a stdin write racing the exit arrives wrapped as
syscall.EPIPE, so no covered case is lost.
Co-authored-by: multica-agent <[email protected]>
---------
Co-authored-by: multica-agent <[email protected]>
Co-authored-by: J <[email protected]>
