mirror of
https://gh-proxy.org/https://github.com/klinsmaya/multica.git
synced 2026-11-08 09:26:50 +08:00
Soda
2a1f393ad2
Use one slash-delimited path contract for skill authoring endpoints and daemon bundle validation. Cover canonical path handling and all public file-write routes with regression tests.
103 lines
2.9 KiB
Go
103 lines
2.9 KiB
Go
package daemon
|
|
|
|
import (
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestSkillBundleCacheLoadStore(t *testing.T) {
|
|
cache := NewSkillBundleCache(t.TempDir())
|
|
bundle := testSkillBundle()
|
|
ref := skillRefFromBundle(bundle)
|
|
|
|
if err := cache.Store("ws-1", bundle); err != nil {
|
|
t.Fatalf("Store: %v", err)
|
|
}
|
|
got, ok := cache.Load("ws-1", ref)
|
|
if !ok {
|
|
t.Fatal("expected cache hit")
|
|
}
|
|
if got.Content != bundle.Content || len(got.Files) != 1 || got.Files[0].Content != "rules" {
|
|
t.Fatalf("unexpected bundle: %+v", got)
|
|
}
|
|
}
|
|
|
|
func TestSkillBundleCacheStoreRetriesRenameWhenDestinationExists(t *testing.T) {
|
|
cache := NewSkillBundleCache(t.TempDir())
|
|
bundle := testSkillBundle()
|
|
ref := skillRefFromBundle(bundle)
|
|
renameCalls := 0
|
|
cache.rename = func(oldPath, newPath string) error {
|
|
renameCalls++
|
|
if renameCalls == 1 {
|
|
if err := os.MkdirAll(newPath, 0o755); err != nil {
|
|
return err
|
|
}
|
|
return &os.LinkError{Op: "rename", Old: oldPath, New: newPath, Err: fs.ErrExist}
|
|
}
|
|
return os.Rename(oldPath, newPath)
|
|
}
|
|
|
|
if err := cache.Store("ws-1", bundle); err != nil {
|
|
t.Fatalf("Store: %v", err)
|
|
}
|
|
if renameCalls != 2 {
|
|
t.Fatalf("rename calls = %d, want 2", renameCalls)
|
|
}
|
|
if _, ok := cache.Load("ws-1", ref); !ok {
|
|
t.Fatal("expected cache hit after EEXIST recovery")
|
|
}
|
|
if _, err := os.Stat(filepath.Dir(cache.bundlePath("ws-1", ref))); err != nil {
|
|
t.Fatalf("stat stored bundle directory: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestSkillBundleCacheRejectsCorruptBundle(t *testing.T) {
|
|
cache := NewSkillBundleCache(t.TempDir())
|
|
bundle := testSkillBundle()
|
|
ref := skillRefFromBundle(bundle)
|
|
if err := cache.Store("ws-1", bundle); err != nil {
|
|
t.Fatalf("Store: %v", err)
|
|
}
|
|
|
|
path := cache.bundlePath("ws-1", ref)
|
|
if err := os.WriteFile(path, []byte(`{"id":"skill-1","source":"workspace","hash":"sha256:bad","content":"tampered"}`), 0o644); err != nil {
|
|
t.Fatalf("tamper cache: %v", err)
|
|
}
|
|
if _, ok := cache.Load("ws-1", ref); ok {
|
|
t.Fatal("expected corrupt cache miss")
|
|
}
|
|
if _, err := os.Stat(path); !os.IsNotExist(err) {
|
|
t.Fatalf("expected corrupt cache file to be removed, stat err=%v", err)
|
|
}
|
|
}
|
|
|
|
// The complete path matrix lives beside skill.IsSafeFilePath. This test only
|
|
// verifies that the daemon wrapper uses the shared contract.
|
|
func TestSafeSkillFilePathUsesSharedContract(t *testing.T) {
|
|
if !safeSkillFilePath("references/example.md") {
|
|
t.Fatal("expected canonical nested path to be accepted")
|
|
}
|
|
if safeSkillFilePath("C:/outside.txt") {
|
|
t.Fatal("expected Windows drive path to be rejected")
|
|
}
|
|
}
|
|
|
|
func testSkillBundle() SkillData {
|
|
bundle := SkillData{
|
|
ID: "skill-1",
|
|
Source: "workspace",
|
|
Name: "deploy",
|
|
Content: "main",
|
|
Files: []SkillFileData{{Path: "rules.md", Content: "rules"}},
|
|
}
|
|
ref := skillRefFromBundle(bundle)
|
|
bundle.Hash = ref.Hash
|
|
bundle.SizeBytes = ref.SizeBytes
|
|
bundle.Files[0].SHA256 = ref.Files[0].SHA256
|
|
bundle.Files[0].SizeBytes = ref.Files[0].SizeBytes
|
|
return bundle
|
|
}
|