mirror of
https://gh-proxy.org/https://github.com/klinsmaya/multica.git
synced 2026-11-09 01:46:46 +08:00
* feat(daemon): worktree mode for local_directory resources (MUL-5707) Local directory resources serialise every task on a per-path mutex, so two tasks on one folder queue behind each other. This adds an opt-in worktree mode: each task gets its own git worktree of the user's repo inside the daemon's env root, so tasks run concurrently and deliver their work as a branch instead of editing the user's working copy. Opt in per resource with execution_mode=worktree (default stays in_place, so existing resources are unchanged). Requires a git repo with at least one commit; a non-git directory fails with an actionable message rather than silently falling back to serial execution. Design points that make the mode safe to use: - The agent starts from what the user sees, not HEAD. Tracked edits are captured with `git stash create` (which writes a commit object without touching the index, working tree, or stash list) and replayed into the worktree; untracked non-ignored files are copied, bounded at 2000 files / 200MB with the skipped count logged at warn level. - That replayed state is committed as a baseline, so "did this task change anything?" has an exact answer and `git diff <baseline>..<branch>` is precisely the agent's work. - Nothing is silently discarded: leftovers are committed to the branch before the worktree is removed, including when the task fails partway. - A task that changes nothing leaves no branch behind. - Sidecars stay out of the branch by running the existing CleanupRuntimeConfig + CleanupSidecars pass over the worktree before finalizing. The .git/info/exclude approach repocache uses is not usable here: a linked worktree resolves info/exclude to the user's own common git dir, so it would change what `git status` hides in their checkout. - Worktree-mode env roots do not get the local_directory GC exemption, so they age out normally instead of accumulating one env root per task. - `git worktree prune` on create self-heals registrations orphaned by a crashed daemon. Adds --execution-mode to `project resource add/update`, and updates the docs and the projects-and-resources built-in skill. Co-authored-by: multica-agent <[email protected]> * fix(daemon): close data-loss and isolation gaps in worktree mode (MUL-5707) Review follow-up on #6759. Six issues, all on failure or skew paths. 1. Preserve work when the final commit fails. Finalize logged a warning and then ran `git worktree remove --force`, destroying the agent's changes. commit.gpgSign with no key available to the daemon triggers this, and --no-verify does not disable signing. Finalize now returns an error and deliberately keeps the worktree — it stays registered, so `git worktree list` points at the work — and the daemon fails the task instead of reporting success with a branch that is missing the changes. 2. Fail closed on an unsupported execution_mode. Treating an unknown mode as in_place was wrong: execution_mode is how a user asks for ISOLATION, so the "safe" fallback would edit the working copy they asked us to stay out of. An unrecognised mode now fails the task naming the version skew. 3. Keep Codex conversations alive across turns. The per-issue session store was keyed on LocalWorkDir != "", so worktree tasks — which also never reuse an env root — got a fresh empty CODEX_HOME per turn and silently lost the thread. Covered by a two-turn regression test that fails without the fix. 4. Fail closed on an incomplete snapshot. A failed stash create/apply, a failed untracked copy, or hitting the copy bounds all degraded to "agent sees HEAD" with only a daemon log line. A half-replayed tree looks like a working checkout, so nothing downstream questions it while the agent reads different code than the user has. All of these now abort the prepare and tear the partial worktree back down. 5. Do not snapshot a directory mid-mutation. The same real path can be attached to another project as an in_place resource; snapshotting under a running in_place task captured a half-written tree plus that task's in-flight .agent_context/.multica sidecars, which then reached the branch and could feed the agent another issue's brief. Worktree prepare now takes the per-path mutex for the snapshot alone (released before the run, so tasks still overlap), and the untracked replay skips Multica's own sidecars. 6. Stop the test helper from masking regressions. gitRun skipped on any git failure, including post-finalize assertions, so a lost branch could report as a skip. Git availability is now checked once at repo setup; every later git failure is fatal. Also rebased onto main, keeping both MulticaConfigRoot and LocalWorktree in the Environment initialiser. Co-authored-by: multica-agent <[email protected]> * fix(daemon): close sidecar-commit and wait-visibility gaps in worktree mode; gate worktree saves on daemon version (MUL-5707) - runTask: register the sidecar-cleanup defer immediately after the Finalize defer. Previously two early returns (temp-dir setup, StartTask failure) sat between them, and on those paths Finalize auto-committed the sidecars Prepare had just written — delivering a branch whose only content is Multica's own runtime files (in_place: leaving them in the user's tree). - runTask: give the worktree snapshot wait the same plumbing as the in-place acquire — waiting_local_directory status, resourceWaitTasks accounting, and a cancellation poller. The holder can be an hours-long in_place task; the wait was invisible and a user cancel went unnoticed until the 5-minute prepare timeout. - isMulticaSidecarPath: match sidecar dirs as whole path segments at any depth, not only at the repo root. An in_place resource pointed at a SUBDIRECTORY leaves its sidecars below that subdirectory; replaying them committed another issue's brief into the delivered branch. - handler: refuse saving execution_mode=worktree while the owning daemon's registered cli_version is below MinLocalWorktreeCLIVersion (422, daemon_version_unsupported). An old daemon json-skips the field and runs tasks IN PLACE — the daemon-side unknown-mode refusal cannot protect a daemon that predates the field, so the server has to. Residual (documented): a daemon downgraded after the save needs a claim-time gate. - copyUntrackedFiles: read the -z listing raw instead of TrimSpace-ing it, which corrupted filenames beginning/ending with whitespace into paths that silently vanished from the replay. - docs + skill: describe the save-time version gate; drop the stale claim that old runtimes fail the task themselves. Co-authored-by: multica-agent <[email protected]> * feat(views): UI switch for local_directory execution mode (MUL-5707) Worktree mode shipped CLI/API-only, which for its target user — someone running several tasks at once from Desktop — means it does not exist. This adds the switch to the resources panel. The choice is framed by what the user gets back, not by the mode identifiers: "Edit this folder directly" (one task at a time, changes land in your working copy) vs "Run in parallel, isolated" (tasks run at the same time and each hands back an agent/… branch). `in_place` / `worktree` stay visible as a secondary hint for anyone cross-referencing the CLI or docs. Two entry points, matching where the decision is actually made: - The add-a-folder flow now asks for the mode after the folder is picked and validated, instead of creating the resource and leaving the mode to be discovered later. - Every local_directory row has a mode control. It is deliberately NOT gated on being the owning machine — switching the mode only rewrites a field, so it works from the web app too, unlike rename or the folder picker. Both blocked states are handled where the user chooses, not after they commit: - Non-git folder: the desktop validator now reports whether the path is inside a git working tree (walking up for `.git`, so a subdirectory of a repo counts), and the option is disabled with that reason. Unknown — an older desktop build, or an existing row — stays permissive; the daemon re-checks authoritatively. - Daemon too old: the version floor is mirrored from the server as MIN_LOCAL_WORKTREE_CLI_VERSION and checked against the runtime for the resource's OWN daemon, not the machine the browser happens to be on. A server rejection is rendered inline in the dialog rather than as a toast, so the dialog stays actionable. A "Parallel" badge on the row is always visible (not hover-only): without it there is no way to tell whether tasks on a folder edit it directly or hand back a branch, which is the first thing anyone asks when a task queues. Also adds `execution_mode` to LocalDirectoryResourceRef — the field existed server-side but had no TypeScript counterpart — and brings the zh/ja/ko project-resources docs in line with the English ones, which were the only locale updated when the mode landed. Co-authored-by: multica-agent <[email protected]> * fix(daemon,handler): close worktree isolation and delivery gaps (MUL-5707) Second review round. Five must-fix items, all on paths where the mode's promises could still break. 1. A failed sidecar cleanup no longer ships Multica's own files as the user's branch. The cleanup errors were logged and Finalize then ran `git add -A`, so a permission/disk/lock failure could deliver a branch whose entire content was the runtime brief and issue context. Worktree mode now escalates a cleanup failure to an abort: nothing is committed, the worktree is kept for inspection, and the task fails with the preserved path. In place it stays a warning — no commit, no branch, and the leftovers are visible in the user's own tree. 2. The untracked replay no longer drops files silently. `Lstat` failures and symlinks were `continue`d without counting, so the caller read a partial snapshot as complete. Both now count as skipped, which the existing fail-closed check turns into a refused prepare. Non-content entries (sockets, FIFOs, devices) stay uncounted deliberately. 3. Prepare rolls back a worktree it created. Any later failure — context files, provider home, MCP config — returned without an Environment, so nothing downstream knew a worktree existed, leaving a registration and a branch no task ever ran in. A deferred Discard now runs unless Prepare reached its successful return. 4. The daemon-version gate moved to where it can actually hold. Save-time validation cannot see a machine downgraded afterwards, and an old daemon json-skips execution_mode entirely — it would run the task in place, editing the working copy the user asked to isolate. Claims are now checked against the runtime that is actually claiming, and a blocked task is cancelled with a reason rather than left to be redelivered to the same too-old runtime forever. 5. branch_name is delivered end to end. The daemon sent it, but TaskCompleteRequest had no field so it vanished at decode, and the failure path never sent it at all. It now has a column, travels on both terminal callbacks, and renders as a copyable row in Run details. The failure path matters most: worktree mode commits the agent's leftovers before tearing the worktree down, so a run that died partway still has work worth finding. Docs (all four locales) and the projects-and-resources skill are updated for the claim-time gate and the branch surface. Co-authored-by: multica-agent <[email protected]> * fix(handler,daemon): migration renumber, cancel reasons, branch on every terminal path (MUL-5707) Third review round. 1. Rebased onto main and renumbered the migration to 285 — main had taken 273 and is now at 284. sqlc regenerated on top of the rebased queries; the conflicts were confined to generated files. 2. The claim gate now persists why it cancelled. It called CancelTask, which writes only status='cancelled', and returned the reason as a 4xx that reaches the daemon's log and nothing else — batch claim drops the task from its response entirely. A run refused for a durable reason the user has to act on cannot present as a bare "cancelled", so this adds CancelAgentTaskWithReason and records error + failure_reason on the row. 3. branch_name now survives every terminal path, not just the two direct callbacks. Three were dropping it: - the context-exhausted complete→fail reroute did not copy it; - the daemon's complete→fail fallback (server rejected the complete, agent had succeeded) did not set it; - both cancellation paths discarded the result wholesale, even though the worktree is finalized — and its work committed — before the daemon learns of the cancel. The branch now rides the cancel-ack and is recorded by SetAgentTaskBranchName, which never overwrites a name a terminal callback already wrote. 4. Rollout/rollback compatibility. Isolation is enforced by two server-side gates, so a daemon downgraded at any point after the resource was saved is caught. The gap they cannot close is rolling the SERVER back past this change while sub-floor daemons are still connected: an old server has no gate and an old daemon ignores execution_mode. That constraint is now documented where an operator will meet it (the migration and the docs), and the version floor is pinned across server and frontend by test so the two gates cannot silently drift apart. Co-authored-by: multica-agent <[email protected]> * fix(server,views): route claim-gate cancels through TaskService, make cancel reasons visible, harden cancel-ack branch delivery (MUL-5707) Closes the fourth-round review findings on worktree mode's cancellation chain: - Claim gate: cancel through a new TaskService.CancelTaskWithReason instead of a raw CancelAgentTaskWithReason query, so a gate-cancelled task gets the full cancellation side effects — audit capture, chat settle, agent status reconcile, task:cancelled broadcast, NotifyTaskFinished. Added REAL claim integration tests: singular claim (422 + row cancelled with reason), batch claim (task omitted + row cancelled with reason), and a current-runtime control. - Cancel reasons are now user-visible: execution log rows, agent activity rows, and the transcript dialog label a SERVER-cancelled task (persisted error/failure_reason) like a failed one, with the actionable text on hover and a Reason row in Run details. User-initiated cancels stay a plain "Cancelled". New cancelReasonLabel helper + local_directory_error label; details_reason locale key in en/zh-Hans/ja/ko; widened AgentTask.failure_reason to the open string the wire actually carries. - Cancel-ack is now a terminal delivery: the daemon retries it on transient errors (same schedule as complete/fail), the server fails LOUD (5xx) when persisting the branch/error fails instead of warn-and-200, and re-broadcasts task:cancelled after a successful write so clients that already refetched a branchless row pick up the delivery. Replays are idempotent (never overwrite). - Cancel + Finalize-abort no longer swallows the preserved-worktree pointer: the finalize error is wrapped in worktreePreservedError (joined onto an existing run error, never displacing it), extracted on the cancel path, and delivered via the ack into agent_task_queue.error through the new SetAgentTaskErrorIfEmpty query — never overwriting a reason recorded by a fail callback or the claim gate. Other run errors on a cancelled run stay discarded as before: they are expected noise. - Docs: the self-hosted rollback constraint callout now exists in zh/ja/ko, not just English. Co-authored-by: multica-agent <[email protected]> * fix(handler): guard cancel-ack writes to cancelled rows; requeue when the claim gate's cancel fails (MUL-5707) Fifth-round review fixes: - SetAgentTaskBranchName / SetAgentTaskErrorIfEmpty now carry a status='cancelled' CAS. The daemon acks on EVERY terminal status it observes, so a late or replayed ack from a stale run could previously backfill its branch or preserved-path error into a completed/failed row whose own callback — the authoritative channel — recorded nothing, without any event invalidating the change. A CAS-refused write is a deliberate no-op (still 200: nothing to retry), and the rebroadcast stays guarded by the same status check. Regression tests: a late ack against a completed row with empty fields and against a failed row leaves both untouched. - When the worktree claim gate's CancelTaskWithReason fails, the claimed row no longer strands in dispatched (daemon refused, nothing to release it but stale reclaim). The gate requeues via RequeueTaskAfterClaimFailure — the next claim re-runs the gate and retries the cancel — and reports 5xx so the singular daemon reads a transient server problem, not a claim refusal; the batch path omits the task as before, now with the row requeued. Fault injection tests (row-scoped trigger raising on the cancel UPDATE while letting the requeue through) cover singular and batch. Co-authored-by: multica-agent <[email protected]> --------- Co-authored-by: Bohan-J <[email protected]> Co-authored-by: multica-agent <[email protected]>
1055 lines
51 KiB
Go
1055 lines
51 KiB
Go
// Package execenv manages isolated per-task execution environments for the daemon.
|
|
// Each task gets its own directory with injected context files. Repositories are
|
|
// checked out on demand by the agent via `multica repo checkout`.
|
|
package execenv
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"log/slog"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"github.com/multica-ai/multica/server/internal/runtimeapps"
|
|
)
|
|
|
|
// RepoContextForEnv describes a workspace repo available for checkout.
|
|
type RepoContextForEnv struct {
|
|
URL string // remote URL
|
|
Description string // optional repo description
|
|
Ref string // optional default checkout ref for this task
|
|
}
|
|
|
|
// ProjectResourceForEnv describes a single resource attached to the issue's
|
|
// project. The resource_ref payload is type-specific JSON; the agent reads
|
|
// resources.json on disk for the full structure. This struct only carries
|
|
// fields the meta-skill template needs to render a human-readable summary
|
|
// (URL for github_repo, generic label otherwise).
|
|
type ProjectResourceForEnv struct {
|
|
ID string `json:"id"` // server-assigned UUID
|
|
ResourceType string `json:"resource_type"` // e.g. "github_repo"
|
|
ResourceRef json.RawMessage `json:"resource_ref"` // raw JSONB payload from the API
|
|
Label string `json:"label,omitempty"` // optional user-supplied label
|
|
}
|
|
|
|
// PrepareParams holds all inputs needed to set up an execution environment.
|
|
type PrepareParams struct {
|
|
WorkspacesRoot string // base path for all envs (e.g., ~/multica_workspaces)
|
|
WorkspaceID string // workspace UUID — tasks are grouped under this
|
|
TaskID string // task UUID — used for directory name
|
|
AgentName string // for git branch naming only
|
|
// Profile is the daemon's profile name (empty = default). It namespaces the
|
|
// per-issue Codex session store so a second profile-daemon sharing the same
|
|
// ~/.codex cannot see or GC this daemon's stores (MUL-4424).
|
|
Profile string
|
|
Provider string // agent provider (determines runtime config and skill injection paths)
|
|
CodexVersion string // detected Codex CLI version (only used when Provider == "codex")
|
|
OpenclawBin string // resolved openclaw CLI path (only used when Provider == "openclaw"); empty = look up on PATH
|
|
// McpConfig is the agent's saved `mcp_config` JSON, forwarded to the
|
|
// provider-specific config preparer when that provider materialises MCP
|
|
// via a per-task config file. Cursor and OpenClaw consume it here; other
|
|
// providers wire MCP via ExecOptions.McpConfig in the agent backend.
|
|
McpConfig json.RawMessage
|
|
// CursorMcpAuthSource is an explicit opt-in path to a Cursor mcp-auth.json
|
|
// file, or the Cursor project data directory containing it. Only Cursor's
|
|
// managed MCP path consumes it.
|
|
CursorMcpAuthSource string
|
|
// OpenclawGateway pins the OpenClaw Gateway endpoint inside the per-task
|
|
// wrapper. Only consulted when Provider == "openclaw" and the agent's
|
|
// runtime_config selected gateway mode (issue #3260). Zero means "inherit
|
|
// whatever the user's global openclaw.json already configures".
|
|
OpenclawGateway OpenclawGatewayPin
|
|
// LocalWorkDir, when non-empty, redirects the agent's working directory
|
|
// to a user-supplied absolute path instead of the synthesised envRoot/
|
|
// workdir. The path is NOT copied or mounted — the agent operates on
|
|
// the user's directory in place. The daemon still creates envRoot for
|
|
// output/, logs/, and .gc_meta.json; only the workdir slot is
|
|
// substituted. Used by the local_directory project_resource flow
|
|
// (MUL-2663). When set, the envRoot/workdir directory is not created.
|
|
LocalWorkDir string
|
|
// LocalWorktree, when non-nil, is the worktree-mode counterpart of
|
|
// LocalWorkDir: instead of running in the user's directory, the task gets
|
|
// its own git worktree of that repo inside envRoot and delivers its work
|
|
// as a branch. Tasks sharing the directory then run concurrently.
|
|
// Mutually exclusive with LocalWorkDir — the daemon picks one based on the
|
|
// resource's execution_mode.
|
|
LocalWorktree *LocalWorktreeParams
|
|
// HermesSourceHome is the shared Hermes home the per-task overlay is seeded
|
|
// from — resolved by the daemon via execenv.ResolveHermesProfile so it honors
|
|
// the agent's custom_env HERMES_HOME and any -p/--profile or sticky selection.
|
|
// Only used for the hermes provider; empty falls back to the platform default.
|
|
HermesSourceHome string
|
|
// HermesSourceMustExist fails the overlay build closed when HermesSourceHome
|
|
// is absent — set when an explicit named profile was requested so a typo
|
|
// doesn't silently seed from an empty home and drop the user's auth/config.
|
|
HermesSourceMustExist bool
|
|
// HermesMemoryStore is the agent's persistent Hermes memory store
|
|
// (HermesMemoryStorePath) the overlay links memories/ to, so memory outlives
|
|
// the task. Empty keeps memories/ task-local — no agent to key on, or the
|
|
// Multica profile dir could not be resolved.
|
|
HermesMemoryStore string
|
|
// HermesSessionStore is the conversation's persistent Hermes session store
|
|
// (HermesSessionStorePath) the overlay links state.db to, so the transcript
|
|
// outlives the task and a follow-up turn can actually resume it. Empty keeps
|
|
// state.db task-local — no agent or conversation to key on, or the Multica
|
|
// profile dir could not be resolved.
|
|
HermesSessionStore string
|
|
// HermesEnv is the sanitized effective env (agent custom_env minus the daemon
|
|
// blocklisted keys) used to expand ${VAR} in Hermes external_dirs so it
|
|
// matches what the Hermes child process actually sees. Only used for hermes.
|
|
HermesEnv map[string]string
|
|
// ReasonixEnv is the sanitized agent custom_env, layered over the daemon's
|
|
// own environment exactly as the child's env is built. The per-task
|
|
// reasonix.toml restates the permissions from the user config that env
|
|
// resolves to, so an agent that re-points (or clears) REASONIX_HOME moves the
|
|
// daemon's read with it. Only used for reasonix.
|
|
ReasonixEnv map[string]string
|
|
// CodexCustomArgs are the effective Codex CLI args this task launches with
|
|
// (daemon defaults + profile-fixed + per-agent custom_args). Only the
|
|
// Windows sandbox decision reads them, to honor a `-c windows.sandbox=...`
|
|
// override that never lands in config.toml (MUL-4957).
|
|
CodexCustomArgs []string
|
|
Task TaskContextForEnv // context data for writing files
|
|
}
|
|
|
|
// TaskContextForEnv is the subset of task context used for writing context files.
|
|
type TaskContextForEnv struct {
|
|
IssueID string
|
|
TriggerCommentID string // comment that triggered this task (empty for on_assign)
|
|
TriggerThreadID string // root comment ID for the triggering thread; falls back to TriggerCommentID when empty
|
|
// CommentReplyTargets is set for a comment run that coalesced comments
|
|
// spanning MORE THAN ONE root thread (MUL-4348). When it has >=2 entries the
|
|
// workflow's reply step fans out — one reply per thread — instead of the
|
|
// single --parent=trigger cookbook, keeping this persistent brief in sync
|
|
// with the per-turn prompt so a cross-thread run cannot get one source
|
|
// telling it "one comment" and the other "one per thread". Same-thread
|
|
// follow-ups collapse to a single group upstream, so this stays empty and
|
|
// the single-parent path is used (no duplicate replies).
|
|
CommentReplyTargets []ThreadReplyTarget
|
|
NewCommentCount int // issue-wide comments since this agent's last run (excludes its own and the injected trigger)
|
|
NewCommentsSince string // RFC3339 anchor (last run's started_at) the count is measured from; empty on cold start
|
|
PriorSessionResumed bool // true when the daemon will resume an existing provider session for this task
|
|
// PriorSessionResumeUnavailable is true when this task carried a prior
|
|
// session the daemon expected to resume but could NOT (the reused workdir was
|
|
// gone, or the Codex rollout was not present in the task CODEX_HOME). The
|
|
// brief surfaces this so the agent tells the user its previous conversation
|
|
// context is gone and this run starts fresh — turning a silent context loss
|
|
// into a user-visible one (MUL-4424). Distinct from an ordinary cold start,
|
|
// which never had a prior session to lose.
|
|
PriorSessionResumeUnavailable bool
|
|
AgentID string // unique ID of the dispatched agent
|
|
AgentName string
|
|
AgentInstructions string // agent identity/persona instructions, injected into CLAUDE.md
|
|
AgentSkills []SkillContextForEnv
|
|
DisabledRuntimeSkills []RuntimeSkillRefForEnv
|
|
Repos []RepoContextForEnv // workspace repos available for checkout
|
|
ProjectID string // active project for this task, when present
|
|
ProjectTitle string // human-readable project title
|
|
ProjectDescription string // durable project-level context, rendered into the brief's Project Context section
|
|
ProjectResources []ProjectResourceForEnv // resources attached to the project
|
|
ChatSessionID string // non-empty for chat tasks
|
|
// ChatChannelType is the IM platform behind a chat session ("slack",
|
|
// "feishu", "wecom"); empty for a web/mobile chat. It names the surface in
|
|
// the brief's copy; what that surface can DELIVER is the separate field
|
|
// below (MUL-4899). The orthogonal audience and history policies live in
|
|
// the per-turn chat prompt (daemon/prompt.go) — the server has no history
|
|
// reader for any other channel.
|
|
ChatChannelType string
|
|
// ChatChannelDeliversFiles is the server's verdict, for THIS turn, on
|
|
// whether a file the agent produces reaches the reader: the adapter goes
|
|
// back for the bound attachment and this deployment has the object storage
|
|
// it goes back to. It arrives on the claim and is used as given. False
|
|
// covers an old server that never sent it, a deployment with no storage,
|
|
// and every channel whose adapter does not perform the hop — all three of
|
|
// which want the same instruction, the one telling the agent to describe
|
|
// its file in words.
|
|
//
|
|
// Carried here but deliberately NOT rendered into the brief. It is a
|
|
// per-turn value: a server upgrade that starts sending it, or object
|
|
// storage being turned on or off, flips it under a chat session that
|
|
// resumes across the change, and the brief is the prompt-cache prefix
|
|
// (MUL-5377). The agent-facing verdict is emitted by the per-turn chat
|
|
// prompt (daemon.buildChatPrompt) instead, and
|
|
// TestBriefByteIdenticalAcrossRunsForEveryKind is what keeps this field out
|
|
// of the brief.
|
|
ChatChannelDeliversFiles bool
|
|
|
|
AutopilotRunID string // non-empty for autopilot run_only tasks
|
|
AutopilotID string
|
|
AutopilotTitle string
|
|
AutopilotDescription string
|
|
AutopilotSource string
|
|
AutopilotTriggerPayload string
|
|
QuickCreatePrompt string // non-empty for quick-create tasks
|
|
HandoffNote string // assignment handoff instruction; rendered into issue_context.md (MUL-3375)
|
|
IsSquadLeader bool // true when THIS TASK runs the agent in the squad-leader role (may exit silently on no_action); derived from the claim's is_leader_task / squad_id, never sniffed from instructions text (MUL-5811)
|
|
// WorkspaceContext is the workspace-level system prompt (workspace.context
|
|
// in the DB). Rendered into the brief as `## Workspace Context` when
|
|
// non-empty so every agent in the workspace sees the same shared context,
|
|
// regardless of issue / chat / autopilot / quick-create.
|
|
WorkspaceContext string
|
|
// ConnectedApps lists per-run external app capabilities mounted through
|
|
// MCP overlays. Rendered briefly so the agent can map app names such as
|
|
// Notion to the actual MCP server name (`composio`).
|
|
ConnectedApps []runtimeapps.ConnectedApp
|
|
// RequestingUserName + RequestingUserProfileDescription describe the
|
|
// human the agent is acting on behalf of. v1 sources them from the
|
|
// runtime owner (the user who registered the daemon). Rendered into the
|
|
// brief as the `## Requesting User` section only when description is
|
|
// non-empty — empty means the user opted out of injecting profile
|
|
// context and the agent stays anonymous-user mode.
|
|
RequestingUserName string
|
|
RequestingUserProfileDescription string
|
|
// Initiator* identify the actor who triggered THIS task (the real
|
|
// requester) as distinct from the runtime owner. Rendered into the brief
|
|
// as `## Task Initiator` when a name is present; InitiatorEmail is shown
|
|
// only for member initiators. Empty for on-assign / autopilot /
|
|
// quick-create tasks, which have no attributable human initiator. See
|
|
// MUL-2645.
|
|
InitiatorType string
|
|
InitiatorID string
|
|
InitiatorName string
|
|
InitiatorEmail string
|
|
}
|
|
|
|
// SkillContextForEnv represents a skill to be written into the execution environment.
|
|
type SkillContextForEnv struct {
|
|
Name string
|
|
Description string
|
|
Content string
|
|
Files []SkillFileContextForEnv
|
|
}
|
|
|
|
// SkillFileContextForEnv represents a supporting file within a skill.
|
|
type SkillFileContextForEnv struct {
|
|
Path string
|
|
Content string
|
|
}
|
|
|
|
// Environment represents a prepared, isolated execution environment.
|
|
type Environment struct {
|
|
// RootDir is the top-level env directory ({workspacesRoot}/{task_id_short}/).
|
|
RootDir string
|
|
// WorkDir is the directory to pass as Cwd to the agent. Normally
|
|
// ({RootDir}/workdir/); when the task is bound to a local_directory
|
|
// project_resource, it is the user's path instead. See LocalDirectory.
|
|
WorkDir string
|
|
// LocalDirectory is true when WorkDir points at a user-supplied path
|
|
// outside RootDir (the local_directory flow). Callers that key behavior
|
|
// on "may I remove WorkDir as scratch?" must check this — for example
|
|
// the GC loop never deletes the user's directory.
|
|
//
|
|
// Deliberately FALSE in worktree mode: there the workdir is a disposable
|
|
// git worktree inside RootDir, so the env root is ordinary daemon-owned
|
|
// scratch that the GC should reclaim on the normal schedule, and the
|
|
// sidecar rollback that protects a user's directory is unnecessary.
|
|
LocalDirectory bool
|
|
// MulticaConfigRoot is the private per-task config directory exported to
|
|
// child CLI invocations. It prevents implicit discovery of the daemon
|
|
// owner's ~/.multica profile without changing the provider-facing HOME.
|
|
MulticaConfigRoot string
|
|
// LocalWorktree is set when the task runs in worktree mode against a
|
|
// local_directory resource. The daemon calls Finalize on it after the
|
|
// agent exits to commit leftovers, drop the worktree, and learn the
|
|
// branch name to report as the task's result.
|
|
LocalWorktree *LocalWorktree
|
|
// CodexHome is the path to the per-task CODEX_HOME directory (set only for codex provider).
|
|
CodexHome string
|
|
// ClaudeSettingsPath is a task-local --settings JSON file that applies
|
|
// disabled runtime-skill policy without mutating the user's Claude config.
|
|
ClaudeSettingsPath string
|
|
// OpenclawConfigPath is the path to the per-task synthesized OpenClaw
|
|
// config (set only for openclaw provider). The daemon exports this as
|
|
// OPENCLAW_CONFIG_PATH on the openclaw subprocess so its native skill
|
|
// scanner pins workspaceDir to WorkDir.
|
|
OpenclawConfigPath string
|
|
// OpenclawIncludeRoot is the directory of the user's active OpenClaw
|
|
// config (set only for openclaw provider with an on-disk user config).
|
|
// The daemon must prepend it to OPENCLAW_INCLUDE_ROOTS so OpenClaw is
|
|
// allowed to follow the wrapper's `$include` link out of envRoot into
|
|
// the user's config — by default OpenClaw confines `$include` to the
|
|
// directory holding the wrapper file. Empty when no $include is
|
|
// emitted (fresh install).
|
|
OpenclawIncludeRoot string
|
|
// CursorDataDir is the per-task Cursor data directory (set only for
|
|
// cursor provider when the agent has managed mcp_config). The daemon
|
|
// exports this as CURSOR_DATA_DIR so project-level MCP approvals are
|
|
// isolated from the user's persistent ~/.cursor/projects state.
|
|
CursorDataDir string
|
|
// HermesHome is the path to the per-task HERMES_HOME overlay (set only for
|
|
// the hermes provider, and only when the agent has skills bound — empty
|
|
// otherwise, leaving the user's real home in place). It mirrors ~/.hermes/
|
|
// via symlink, derives a config.yaml that references the user's real skills
|
|
// as an external root, and holds the bound skills in its skills/ subdir. The
|
|
// daemon exports it as HERMES_HOME so the hermes CLI discovers those skills
|
|
// natively — Hermes has no workspace-relative discovery, so the previous
|
|
// .agent_context/skills/ fallback was never read (issue #5242). See
|
|
// hermes_home.go.
|
|
HermesHome string
|
|
// HermesSessionStore is the conversation's session store this task's
|
|
// state.db is actually linked to, or "" when the session database stayed
|
|
// task-local (no store to key on, or a host that could not create the
|
|
// link).
|
|
HermesSessionStore string
|
|
// HermesSessionHistoryPresent reports that the mounted store actually holds
|
|
// a session database — a prior turn's transcript this task can resume.
|
|
// Mounting alone does not imply it: a conversation's first turn, a store the
|
|
// GC reclaimed between turns, a switched Hermes profile and an operator's
|
|
// `rm` all mount cleanly onto nothing. The daemon reads THIS, not the store
|
|
// path, as the answer to "can a prior session id still resolve here?" — see
|
|
// gateResumeToReusedWorkdir.
|
|
HermesSessionHistoryPresent bool
|
|
// QwenpawWorkspace is the path to the per-task QwenPaw workspace directory
|
|
// (set only for the qwenpaw provider). It is populated with the bound skills
|
|
// and their skill.json manifest with enabled: true, so the skills are
|
|
// immediately effective. The daemon passes --workspace <dir> to
|
|
// `qwenpaw acp` so the QwenPaw agent discovers the skills natively.
|
|
// See qwenpaw_workspace.go.
|
|
QwenpawWorkspace string
|
|
|
|
logger *slog.Logger // for cleanup logging
|
|
}
|
|
|
|
// PredictRootDir returns the env root path that Prepare would create for the
|
|
// given task, without performing any I/O. Callers use this to claim ownership
|
|
// of the directory (e.g. against the GC loop) before Prepare/Reuse runs.
|
|
func PredictRootDir(workspacesRoot, workspaceID, taskID string) string {
|
|
if workspacesRoot == "" || workspaceID == "" || taskID == "" {
|
|
return ""
|
|
}
|
|
return filepath.Join(workspacesRoot, workspaceID, shortID(taskID))
|
|
}
|
|
|
|
// Prepare creates an isolated execution environment for a task.
|
|
// The workdir starts empty (no repo checkouts). The agent checks out repos
|
|
// on demand via `multica repo checkout <url>`.
|
|
func Prepare(params PrepareParams, logger *slog.Logger) (*Environment, error) {
|
|
if params.WorkspacesRoot == "" {
|
|
return nil, fmt.Errorf("execenv: workspaces root is required")
|
|
}
|
|
if params.WorkspaceID == "" {
|
|
return nil, fmt.Errorf("execenv: workspace ID is required")
|
|
}
|
|
if params.TaskID == "" {
|
|
return nil, fmt.Errorf("execenv: task ID is required")
|
|
}
|
|
|
|
envRoot := filepath.Join(params.WorkspacesRoot, params.WorkspaceID, shortID(params.TaskID))
|
|
|
|
// Self-heal the root-level daemon marker on every task start so a marker
|
|
// removed while the daemon runs is restored before the agent spawns. The
|
|
// per-workdir marker written below only covers cwds inside the workdir;
|
|
// the root marker keeps the CLI fail-closed guard active for subprocesses
|
|
// that lose all MULTICA_* env vars AND escape above the workdir. Non-fatal:
|
|
// without it the workdir marker still protects the common case.
|
|
if err := EnsureWorkspacesRootMarker(params.WorkspacesRoot); err != nil && logger != nil {
|
|
logger.Warn("execenv: workspaces root marker not written; fail-closed guard limited to the task workdir", "error", err)
|
|
}
|
|
|
|
// Remove existing env if present (defensive — task IDs are unique).
|
|
if _, err := os.Stat(envRoot); err == nil {
|
|
if err := os.RemoveAll(envRoot); err != nil {
|
|
return nil, fmt.Errorf("execenv: remove existing env: %w", err)
|
|
}
|
|
}
|
|
|
|
// Create directory tree. For the standard flow the agent's workdir is
|
|
// envRoot/workdir; for local_directory tasks the user's path takes its
|
|
// place and we only need to create the scratch directories under
|
|
// envRoot.
|
|
workDir := filepath.Join(envRoot, "workdir")
|
|
scratchDirs := []string{filepath.Join(envRoot, "output"), filepath.Join(envRoot, "logs")}
|
|
if params.LocalWorkDir == "" && params.LocalWorktree == nil {
|
|
scratchDirs = append(scratchDirs, workDir)
|
|
} else if params.LocalWorkDir != "" {
|
|
workDir = params.LocalWorkDir
|
|
}
|
|
for _, dir := range scratchDirs {
|
|
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
return nil, fmt.Errorf("execenv: create directory %s: %w", dir, err)
|
|
}
|
|
}
|
|
multicaConfigRoot := filepath.Join(envRoot, "multica-config")
|
|
if err := os.MkdirAll(multicaConfigRoot, 0o700); err != nil {
|
|
return nil, fmt.Errorf("execenv: create task-local Multica config directory: %w", err)
|
|
}
|
|
if err := os.Chmod(multicaConfigRoot, 0o700); err != nil {
|
|
return nil, fmt.Errorf("execenv: restrict task-local Multica config directory: %w", err)
|
|
}
|
|
|
|
// Worktree mode: build the task's own checkout of the user's repo inside
|
|
// envRoot and use it as the workdir. Done before any context file is
|
|
// written so the sidecars land inside the disposable worktree instead of
|
|
// the user's directory.
|
|
var localWorktree *LocalWorktree
|
|
// Tracks whether Prepare reached its successful return. Everything after
|
|
// worktree creation can still fail — context files, provider homes, MCP
|
|
// config — and on those paths the caller never receives an Environment, so
|
|
// nothing downstream knows a worktree exists to clean up. Without the
|
|
// rollback below, each such failure would leave a registration in the
|
|
// user's repo and a branch that no task ever ran in.
|
|
prepareSucceeded := false
|
|
if params.LocalWorktree != nil {
|
|
wtParams := *params.LocalWorktree
|
|
wtParams.EnvRoot = envRoot
|
|
wtParams.AgentName = params.AgentName
|
|
wtParams.TaskID = params.TaskID
|
|
var err error
|
|
localWorktree, err = PrepareLocalWorktree(wtParams, logger)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer func() {
|
|
if prepareSucceeded {
|
|
return
|
|
}
|
|
// Safe to discard unconditionally: no agent has run yet, so the
|
|
// worktree holds only what Prepare itself put there.
|
|
localWorktree.Discard(logger)
|
|
}()
|
|
workDir = localWorktree.WorkDir
|
|
// The resource may point at a subdirectory that holds only ignored
|
|
// files, in which case git doesn't materialise it in the worktree.
|
|
if err := os.MkdirAll(workDir, 0o755); err != nil {
|
|
return nil, fmt.Errorf("execenv: create worktree workdir %s: %w", workDir, err)
|
|
}
|
|
}
|
|
|
|
env := &Environment{
|
|
RootDir: envRoot,
|
|
WorkDir: workDir,
|
|
LocalDirectory: params.LocalWorkDir != "",
|
|
LocalWorktree: localWorktree,
|
|
MulticaConfigRoot: multicaConfigRoot,
|
|
logger: logger,
|
|
}
|
|
|
|
// Write context files into workdir (skills go to provider-native paths).
|
|
// Track every file/dir we create in a manifest so CleanupSidecars can
|
|
// roll a local_directory workdir back to its pre-Prepare state. Cloud
|
|
// tasks don't need the manifest (the GC loop wipes envRoot wholesale),
|
|
// but we always write one — it's cheap, keeps Prepare/Reuse symmetric,
|
|
// and avoids a conditional that would silently disable cleanup if the
|
|
// local_directory detection logic ever drifts.
|
|
manifest := &sidecarManifest{}
|
|
if err := writeContextFiles(workDir, params.Provider, params.Task, manifest); err != nil {
|
|
return nil, fmt.Errorf("execenv: write context files: %w", err)
|
|
}
|
|
|
|
// Persist managed-env provenance for non-local issue envs at Prepare time
|
|
// (not on completion, where .gc_meta.json is written). A same-issue
|
|
// follow-up can be claimed the instant the prior task completes — before
|
|
// the prior handler writes .gc_meta.json — so reuse eligibility must be
|
|
// provable from an artifact that exists the moment the env is created. Only
|
|
// managed (non-local_directory) issue envs get this marker; that is exactly
|
|
// the set squad-leader reuse targets (MUL-4886). Non-fatal: a write failure
|
|
// only costs the next follow-up its session reuse (it falls back to a fresh
|
|
// session), which must never block dispatching this task.
|
|
if params.LocalWorkDir == "" && params.Task.IssueID != "" {
|
|
if err := WriteManagedEnvProvenance(envRoot, ManagedEnvProvenance{
|
|
WorkspaceID: params.WorkspaceID,
|
|
IssueID: params.Task.IssueID,
|
|
AgentID: params.Task.AgentID,
|
|
}); err != nil && logger != nil {
|
|
logger.Warn("execenv: write managed env provenance failed (non-fatal); a follow-up may start a fresh session", "error", err)
|
|
}
|
|
}
|
|
|
|
// For Codex, set up a per-task CODEX_HOME seeded from ~/.codex/ with skills.
|
|
if params.Provider == "codex" {
|
|
codexHome := filepath.Join(envRoot, codexHomeDirName)
|
|
if err := prepareCodexHomeWithOpts(codexHome, CodexHomeOptions{CodexVersion: params.CodexVersion, IsLocalDirectory: params.LocalWorkDir != "" || params.LocalWorktree != nil, SessionStoreKey: codexSessionStoreKey(params.Profile, params.Task), CodexCustomArgs: params.CodexCustomArgs}, logger); err != nil {
|
|
return nil, fmt.Errorf("execenv: prepare codex-home: %w", err)
|
|
}
|
|
if err := hydrateCodexSkills(codexHome, params.Task.AgentSkills, params.Task.DisabledRuntimeSkills, logger); err != nil {
|
|
return nil, fmt.Errorf("execenv: hydrate codex skills: %w", err)
|
|
}
|
|
env.CodexHome = codexHome
|
|
}
|
|
|
|
if params.Provider == "claude" {
|
|
settingsPath, err := prepareClaudeSkillSettings(envRoot, params.Task.DisabledRuntimeSkills, params.Task.AgentSkills)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("execenv: prepare claude skill settings: %w", err)
|
|
}
|
|
env.ClaudeSettingsPath = settingsPath
|
|
}
|
|
|
|
// For Hermes, redirect HERMES_HOME to a per-task compatibility overlay ONLY
|
|
// when the agent has skills bound. A skill-less Hermes task keeps the user's
|
|
// real home and its original behavior untouched. The overlay makes the bound
|
|
// skills visible — Hermes discovers skills only from its home, so the old
|
|
// .agent_context/skills/ fallback was never read (issue #5242). See
|
|
// hermes_home.go.
|
|
//
|
|
// Note this is a local contract, not an observable product behaviour: the
|
|
// server appends the platform's built-in skills to every agent's skill set
|
|
// (service.LoadAgentSkillBundles), so a claimed task's AgentSkills is never
|
|
// empty and the skill-less branch is effectively unreachable in production.
|
|
// Emptying an agent's own skill list is NOT a way to opt out of the overlay.
|
|
if params.Provider == "hermes" && len(params.Task.AgentSkills) > 0 {
|
|
hermesHome := filepath.Join(envRoot, "hermes-home")
|
|
sessions, err := prepareHermesHome(hermesHome, params.HermesSourceHome, params.HermesSourceMustExist, params.Task.AgentSkills, params.HermesEnv, params.HermesMemoryStore, params.HermesSessionStore, logger)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("execenv: prepare hermes-home: %w", err)
|
|
}
|
|
env.HermesHome = hermesHome
|
|
if sessions.Mounted {
|
|
env.HermesSessionStore = params.HermesSessionStore
|
|
env.HermesSessionHistoryPresent = sessions.HistoryPresent
|
|
}
|
|
}
|
|
if params.Provider == "qwenpaw" {
|
|
qwenpawWorkspace := filepath.Join(envRoot, "qwenpaw-workspace")
|
|
if err := prepareQwenpawWorkspace(qwenpawWorkspace, params.Task.AgentSkills, logger); err != nil {
|
|
return nil, fmt.Errorf("execenv: prepare qwenpaw workspace: %w", err)
|
|
}
|
|
env.QwenpawWorkspace = qwenpawWorkspace
|
|
}
|
|
|
|
// For Reasonix, deny the `ask` tool for this task through a project-scoped
|
|
// reasonix.toml. Degraded, not fatal: without it the task still runs under
|
|
// the backend's fail-closed question handling.
|
|
if params.Provider == "reasonix" {
|
|
if err := writeReasonixProjectConfig(workDir, params.ReasonixEnv, manifest, logger); err != nil {
|
|
logger.Warn("execenv: write reasonix project config failed", "error", err)
|
|
}
|
|
}
|
|
|
|
// For Cursor, materialize managed MCP into project-local config and use
|
|
// an isolated CURSOR_DATA_DIR for the per-workdir approval sidecar. Cursor
|
|
// still reads ~/.cursor/mcp.json, but only servers with approval entries in
|
|
// this per-task data dir can load, so user-global MCP servers do not leak
|
|
// into managed-MCP runs.
|
|
if params.Provider == "cursor" {
|
|
cursorDataDir, err := prepareCursorMcpConfig(envRoot, workDir, params.McpConfig, params.CursorMcpAuthSource, manifest)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("execenv: prepare cursor mcp config: %w", err)
|
|
}
|
|
env.CursorDataDir = cursorDataDir
|
|
}
|
|
|
|
if err := writeSidecarManifest(envRoot, manifest); err != nil {
|
|
logger.Warn("execenv: write sidecar manifest failed (non-fatal)", "error", err)
|
|
}
|
|
|
|
// For OpenClaw, synthesize a per-task config that pins workspace to
|
|
// workDir. The skill scanner then reads {workDir}/skills/ (written by
|
|
// writeContextFiles above). Fail closed on errors: a malformed user
|
|
// config that the openclaw CLI can't read is a real problem and
|
|
// silently degrading to a minimal config would mask it by booting
|
|
// OpenClaw without the agents / providers / API keys it expects.
|
|
if params.Provider == "openclaw" {
|
|
result, err := prepareOpenclawConfig(envRoot, workDir, OpenclawConfigPrep{
|
|
OpenclawBin: params.OpenclawBin,
|
|
McpConfig: params.McpConfig,
|
|
Gateway: params.OpenclawGateway,
|
|
Logger: logger,
|
|
})
|
|
if err != nil {
|
|
return nil, fmt.Errorf("execenv: prepare openclaw config: %w", err)
|
|
}
|
|
env.OpenclawConfigPath = result.ConfigPath
|
|
env.OpenclawIncludeRoot = result.IncludeRoot
|
|
}
|
|
|
|
logger.Info("execenv: prepared env", "root", envRoot, "repos_available", len(params.Task.Repos))
|
|
prepareSucceeded = true
|
|
return env, nil
|
|
}
|
|
|
|
// ReuseParams describes the inputs to Reuse. It mirrors PrepareParams for
|
|
// the per-provider knobs (CodexVersion, OpenclawBin) so callers can pass
|
|
// the same resolved binary path on both first-run and reuse paths.
|
|
type ReuseParams struct {
|
|
// WorkspacesRoot is the daemon-owned root under which all task envs live.
|
|
// Passed on reuse so the root-level fail-closed marker is self-healed here
|
|
// too — a marker removed while the daemon runs is restored before a reused
|
|
// task spawns, not only on the fresh-Prepare path.
|
|
WorkspacesRoot string
|
|
WorkDir string
|
|
Provider string
|
|
CodexVersion string // only used when Provider == "codex"
|
|
// ResumeSessionID is the prior Codex thread/session ID this reused task
|
|
// intends to resume, when any. Only consulted when Provider == "codex" and
|
|
// only used while migrating a legacy per-task home whose sessions/ still
|
|
// symlinks the shared ~/.codex/sessions — the single rollout for this ID is
|
|
// exposed into the new task-local sessions dir so thread/resume still finds
|
|
// it. Empty means a fresh thread. See prepareCodexSessionsDir (MUL-4424).
|
|
ResumeSessionID string
|
|
OpenclawBin string // only used when Provider == "openclaw"; empty = PATH lookup
|
|
// McpConfig is the agent's saved `mcp_config` JSON. Reused on reuse so a
|
|
// freshly-saved managed set re-materialises into the wrapper before the
|
|
// task starts — without this a stale wrapper from a prior run would keep
|
|
// the old MCP set in play.
|
|
McpConfig json.RawMessage
|
|
// CursorMcpAuthSource mirrors PrepareParams.CursorMcpAuthSource on reuse.
|
|
CursorMcpAuthSource string
|
|
// OpenclawGateway is the per-task Gateway pin re-applied on reuse so the
|
|
// agent picks up any runtime_config changes saved since the prior run.
|
|
OpenclawGateway OpenclawGatewayPin
|
|
// Profile is the daemon's profile name (empty = default), mirroring
|
|
// PrepareParams.Profile so a reused task keys its per-issue Codex session
|
|
// store into the same profile namespace (MUL-4424).
|
|
Profile string
|
|
// LocalDirectory is true when the reused WorkDir is a user-supplied
|
|
// directory (the local_directory flow). The flag is propagated into
|
|
// the returned Environment so downstream callers (notably the GC
|
|
// loop) keep the "never delete the user's directory" invariant on
|
|
// reuse paths.
|
|
LocalDirectory bool
|
|
// HermesSourceHome, HermesEnv, HermesMemoryStore and HermesSessionStore
|
|
// mirror PrepareParams on reuse so the Hermes overlay re-derives against the
|
|
// agent's current source home / profile, external_dirs vars, memory store and
|
|
// conversation session store.
|
|
HermesSourceHome string
|
|
HermesSourceMustExist bool
|
|
HermesEnv map[string]string
|
|
HermesMemoryStore string
|
|
HermesSessionStore string
|
|
// ReasonixEnv mirrors PrepareParams.ReasonixEnv on reuse so the rewritten
|
|
// reasonix.toml keeps restating the owner's current permissions.
|
|
ReasonixEnv map[string]string
|
|
// CodexCustomArgs mirrors PrepareParams.CodexCustomArgs on reuse so the
|
|
// Windows sandbox decision honors a `-c windows.sandbox=...` override here
|
|
// too (MUL-4957).
|
|
CodexCustomArgs []string
|
|
Task TaskContextForEnv // refreshed context files / skills
|
|
}
|
|
|
|
// Reuse wraps an existing workdir into an Environment and refreshes context files.
|
|
// Returns nil if the workdir does not exist (caller should fall back to Prepare).
|
|
func Reuse(params ReuseParams, logger *slog.Logger) *Environment {
|
|
if _, err := os.Stat(params.WorkDir); err != nil {
|
|
return nil
|
|
}
|
|
|
|
// Self-heal the root-level daemon marker on the reuse path too, so a marker
|
|
// removed while the daemon runs is restored before a reused task spawns —
|
|
// otherwise reuse could run without the fail-closed guard until the next
|
|
// fresh Prepare. Non-fatal: the per-workdir marker still protects the common
|
|
// case, and an empty WorkspacesRoot (legacy callers) simply skips this.
|
|
if params.WorkspacesRoot != "" {
|
|
if err := EnsureWorkspacesRootMarker(params.WorkspacesRoot); err != nil && logger != nil {
|
|
logger.Warn("execenv: workspaces root marker not written on reuse; fail-closed guard limited to the task workdir", "error", err)
|
|
}
|
|
}
|
|
|
|
rootDir := filepath.Dir(params.WorkDir)
|
|
if params.LocalDirectory {
|
|
// For local_directory tasks the user's WorkDir is unrelated to
|
|
// envRoot (envRoot still lives under workspacesRoot/{wsID}/...),
|
|
// so reading it from filepath.Dir(WorkDir) would point at the
|
|
// parent of the user's directory. Callers that need a real
|
|
// RootDir on the reuse path should arrange to pass it in
|
|
// explicitly; for v1 the daemon only ever reuses local_directory
|
|
// workdirs after a fresh Prepare in the same task lifetime, so
|
|
// the empty RootDir on reuse is fine for the current callers
|
|
// (GC writes meta from Prepare's result, not Reuse's).
|
|
rootDir = ""
|
|
}
|
|
env := &Environment{
|
|
RootDir: rootDir,
|
|
WorkDir: params.WorkDir,
|
|
LocalDirectory: params.LocalDirectory,
|
|
logger: logger,
|
|
}
|
|
if env.RootDir != "" {
|
|
env.MulticaConfigRoot = filepath.Join(env.RootDir, "multica-config")
|
|
if err := os.MkdirAll(env.MulticaConfigRoot, 0o700); err != nil {
|
|
logger.Warn("execenv: restore task-local Multica config directory failed; forcing fresh prepare", "error", err)
|
|
return nil
|
|
}
|
|
if err := os.Chmod(env.MulticaConfigRoot, 0o700); err != nil {
|
|
logger.Warn("execenv: restrict task-local Multica config directory failed; forcing fresh prepare", "error", err)
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// Roll back the previous dispatch's sidecar writes before refreshing.
|
|
// On reuse the workdir still holds the prior run's issue_context.md and
|
|
// skill directories; without clearing them first, writeSkillFiles sees
|
|
// its own earlier output occupying the canonical slug and falls back to
|
|
// a collision-free sibling (issue-review, issue-review-multica,
|
|
// issue-review-multica-2, …), accumulating a fresh duplicate on every
|
|
// re-dispatch to the same issue. allocateCollisionFreeSkillDir exists to
|
|
// dodge *user*-owned skill dirs (the local_directory flow), not our own
|
|
// prior writes, so we undo them via the prior manifest first and let the
|
|
// refresh below re-create each skill at its natural slug. This also brings
|
|
// the standard providers in line with the Codex path, where
|
|
// hydrateCodexSkills already wipes its skills dir before re-hydrating.
|
|
//
|
|
// Two steps, in order:
|
|
// 1. removeReusedManagedSkillDirs reclaims the platform's own skill
|
|
// directories even when a prior-run agent left a file inside one.
|
|
// CleanupSidecars alone can't do this — it preserves any recorded dir
|
|
// the agent populated (correct on the local_directory teardown path),
|
|
// which would otherwise keep the canonical slug occupied and push the
|
|
// refresh back to issue-review-multica.
|
|
// 2. CleanupSidecars rolls back the remaining sidecar files
|
|
// (issue_context.md, project resources) and the manifest itself.
|
|
//
|
|
// No-op when RootDir is empty (legacy local_directory reuse, which the
|
|
// daemon skips anyway) or when no prior manifest exists (older build).
|
|
if env.RootDir != "" {
|
|
if err := removeReusedManagedSkillDirs(env.RootDir, skillsDirPath(params.WorkDir, params.Provider)); err != nil {
|
|
logger.Warn("execenv: reclaim managed skill dirs on reuse failed", "error", err)
|
|
}
|
|
if err := CleanupSidecars(env.RootDir); err != nil {
|
|
logger.Warn("execenv: roll back prior sidecars on reuse failed", "error", err)
|
|
}
|
|
}
|
|
|
|
// Refresh context files (issue_context.md, skills). Reuse tracks a
|
|
// fresh manifest under env.RootDir so a later CleanupSidecars sees
|
|
// the up-to-date list of writes (an old manifest from a prior run
|
|
// would otherwise reference files this Reuse no longer creates). For
|
|
// local_directory tasks the daemon skips Reuse entirely (see
|
|
// daemon.runTask), but writing the manifest unconditionally keeps
|
|
// Prepare/Reuse symmetric so a future caller can rely on the
|
|
// manifest being current after either path. RootDir is empty on the
|
|
// legacy local_directory Reuse fallback — skip the persist in that
|
|
// case to avoid creating a stray manifest at the filesystem root.
|
|
manifest := &sidecarManifest{}
|
|
if err := writeContextFiles(params.WorkDir, params.Provider, params.Task, manifest); err != nil {
|
|
logger.Warn("execenv: refresh context files failed", "error", err)
|
|
}
|
|
|
|
// Restore CodexHome for Codex provider — the per-task codex-home directory
|
|
// lives alongside the workdir. Re-run prepareCodexHomeWithOpts to ensure
|
|
// config (especially sandbox/network access) is up to date.
|
|
if params.Provider == "codex" {
|
|
codexHome := filepath.Join(env.RootDir, codexHomeDirName)
|
|
if err := prepareCodexHomeWithOpts(codexHome, CodexHomeOptions{CodexVersion: params.CodexVersion, ResumeSessionID: params.ResumeSessionID, IsLocalDirectory: params.LocalDirectory, SessionStoreKey: codexSessionStoreKey(params.Profile, params.Task), CodexCustomArgs: params.CodexCustomArgs}, logger); err != nil {
|
|
logger.Warn("execenv: refresh codex-home failed", "error", err)
|
|
} else {
|
|
env.CodexHome = codexHome
|
|
if err := hydrateCodexSkills(codexHome, params.Task.AgentSkills, params.Task.DisabledRuntimeSkills, logger); err != nil {
|
|
logger.Warn("execenv: refresh codex skills failed", "error", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
if params.Provider == "claude" && env.RootDir != "" {
|
|
settingsPath, err := prepareClaudeSkillSettings(env.RootDir, params.Task.DisabledRuntimeSkills, params.Task.AgentSkills)
|
|
if err != nil {
|
|
logger.Warn("execenv: refresh claude skill settings failed", "error", err)
|
|
} else {
|
|
env.ClaudeSettingsPath = settingsPath
|
|
}
|
|
}
|
|
|
|
// Re-deny Reasonix's `ask` tool on reuse: CleanupSidecars above removed the
|
|
// prior run's reasonix.toml, so without this the next turn would run with
|
|
// the tool available again.
|
|
if params.Provider == "reasonix" {
|
|
if err := writeReasonixProjectConfig(params.WorkDir, params.ReasonixEnv, manifest, logger); err != nil {
|
|
logger.Warn("execenv: refresh reasonix project config failed", "error", err)
|
|
}
|
|
}
|
|
|
|
// Refresh (or tear down) the per-task QwenPaw workspace on reuse.
|
|
// Rebuild the workspace so an added/removed/edited skill is reflected.
|
|
if params.Provider == "qwenpaw" && env.RootDir != "" {
|
|
qwenpawWorkspace := filepath.Join(env.RootDir, "qwenpaw-workspace")
|
|
if err := prepareQwenpawWorkspace(qwenpawWorkspace, params.Task.AgentSkills, logger); err != nil {
|
|
logger.Warn("execenv: refresh qwenpaw workspace failed; forcing fresh prepare", "error", err)
|
|
return nil
|
|
}
|
|
env.QwenpawWorkspace = qwenpawWorkspace
|
|
}
|
|
|
|
// Refresh (or tear down) the per-task HERMES_HOME on reuse. With skills
|
|
// bound, rebuild the overlay so an added/removed/edited skill and the
|
|
// mirrored home/config track the user's current ~/.hermes/ before the next
|
|
// hermes process starts. With no skills bound, drop the redirect entirely so
|
|
// the task reverts to the user's real home — matching a fresh Prepare for a
|
|
// skill-less agent.
|
|
if params.Provider == "hermes" && env.RootDir != "" {
|
|
hermesHome := filepath.Join(env.RootDir, "hermes-home")
|
|
if len(params.Task.AgentSkills) > 0 {
|
|
sessions, err := prepareHermesHome(hermesHome, params.HermesSourceHome, params.HermesSourceMustExist, params.Task.AgentSkills, params.HermesEnv, params.HermesMemoryStore, params.HermesSessionStore, logger)
|
|
if err != nil {
|
|
// Fail closed: a half-built overlay must not run. Returning nil
|
|
// makes the daemon fall back to a fresh Prepare, whose error
|
|
// then blocks dispatch rather than silently dropping the bound
|
|
// skill.
|
|
logger.Warn("execenv: refresh hermes-home failed; forcing fresh prepare", "error", err)
|
|
return nil
|
|
}
|
|
env.HermesHome = hermesHome
|
|
env.HermesSessionStore = ""
|
|
env.HermesSessionHistoryPresent = false
|
|
if sessions.Mounted {
|
|
env.HermesSessionStore = params.HermesSessionStore
|
|
env.HermesSessionHistoryPresent = sessions.HistoryPresent
|
|
}
|
|
} else {
|
|
env.HermesHome = ""
|
|
env.HermesSessionStore = ""
|
|
env.HermesSessionHistoryPresent = false
|
|
if err := os.RemoveAll(hermesHome); err != nil {
|
|
logger.Warn("execenv: remove stale hermes-home failed", "error", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Refresh Cursor's managed MCP sidecars on reuse. A newly saved agent
|
|
// mcp_config must replace the prior run's .cursor/mcp.json and isolated
|
|
// approvals before the next cursor-agent process starts.
|
|
if params.Provider == "cursor" && env.RootDir != "" {
|
|
cursorDataDir, err := prepareCursorMcpConfig(env.RootDir, params.WorkDir, params.McpConfig, params.CursorMcpAuthSource, manifest)
|
|
if err != nil {
|
|
logger.Warn("execenv: refresh cursor mcp config failed", "error", err)
|
|
return nil
|
|
}
|
|
env.CursorDataDir = cursorDataDir
|
|
}
|
|
|
|
if env.RootDir != "" {
|
|
if err := writeSidecarManifest(env.RootDir, manifest); err != nil {
|
|
logger.Warn("execenv: refresh sidecar manifest failed", "error", err)
|
|
}
|
|
}
|
|
|
|
// Refresh the per-task OpenClaw config on reuse — the user may have
|
|
// added/removed agents or rotated providers since the prior task ran,
|
|
// and the workspace override always re-targets the current workDir.
|
|
// Fail closed: a user config that can no longer be parsed should block
|
|
// reuse rather than degrade to a minimal config that boots OpenClaw
|
|
// without the registered agents.
|
|
if params.Provider == "openclaw" {
|
|
result, err := prepareOpenclawConfig(env.RootDir, params.WorkDir, OpenclawConfigPrep{
|
|
OpenclawBin: params.OpenclawBin,
|
|
McpConfig: params.McpConfig,
|
|
Gateway: params.OpenclawGateway,
|
|
Logger: logger,
|
|
})
|
|
if err != nil {
|
|
logger.Warn("execenv: refresh openclaw config failed", "error", err)
|
|
return nil
|
|
}
|
|
env.OpenclawConfigPath = result.ConfigPath
|
|
env.OpenclawIncludeRoot = result.IncludeRoot
|
|
}
|
|
|
|
logger.Info("execenv: reusing env", "workdir", params.WorkDir)
|
|
return env
|
|
}
|
|
|
|
// hydrateCodexSkills populates the per-task CODEX_HOME/skills directory with
|
|
// both user-installed skills (from the shared ~/.codex/skills/) and
|
|
// workspace-assigned skills. Workspace skills win on name conflict — they are
|
|
// written last and seedUserCodexSkills already pre-filters their names.
|
|
//
|
|
// The skills directory is wiped first so two stale-state classes that the
|
|
// Reuse path would otherwise leak are gone:
|
|
//
|
|
// - A name now claimed by a workspace skill that previously held only a
|
|
// user-seeded copy — support files from the user version would otherwise
|
|
// linger under the workspace skill's directory.
|
|
// - A user skill removed from the shared ~/.codex/skills/ since the last
|
|
// run — its old contents would otherwise remain visible to the codex
|
|
// CLI.
|
|
//
|
|
// Codex is the only runtime that needs this two-stage hydration because the
|
|
// daemon sets CODEX_HOME to a per-task directory, isolating the CLI from the
|
|
// user's real ~/.codex/. Other runtimes leave HOME untouched and discover
|
|
// user-level skills natively (see context.go for the workdir-local paths
|
|
// they use for workspace skills).
|
|
func hydrateCodexSkills(codexHome string, workspaceSkills []SkillContextForEnv, disabledRuntimeSkills []RuntimeSkillRefForEnv, logger *slog.Logger) error {
|
|
skillsDir := filepath.Join(codexHome, "skills")
|
|
if err := os.RemoveAll(skillsDir); err != nil {
|
|
return fmt.Errorf("clear codex skills dir: %w", err)
|
|
}
|
|
if err := seedUserCodexSkills(codexHome, workspaceSkills, logger); err != nil {
|
|
logger.Warn("execenv: seed user codex skills failed", "error", err)
|
|
}
|
|
if len(workspaceSkills) > 0 {
|
|
if err := writeSkillFiles(skillsDir, workspaceSkills, nil); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return ensureCodexDisabledSkillsConfig(filepath.Join(codexHome, "config.toml"), codexHome, disabledRuntimeSkills, workspaceSkills)
|
|
}
|
|
|
|
// GCMetaKind identifies which kind of parent record a task workdir belongs to.
|
|
// The GC loop dispatches its decision tree on this value so chat / autopilot /
|
|
// quick-create tasks are no longer forced through the issue-centric path.
|
|
type GCMetaKind string
|
|
|
|
const (
|
|
GCKindIssue GCMetaKind = "issue"
|
|
GCKindChat GCMetaKind = "chat"
|
|
GCKindAutopilotRun GCMetaKind = "autopilot_run"
|
|
GCKindQuickCreate GCMetaKind = "quick_create"
|
|
)
|
|
|
|
// GCMeta is persisted to .gc_meta.json inside the env root so the GC loop
|
|
// can decide whether the directory is reclaimable. It is a discriminated
|
|
// union keyed on Kind: only the ID field matching Kind is meaningful.
|
|
//
|
|
// Older meta files (pre-v2) lack the Kind field; readers must default empty
|
|
// Kind to GCKindIssue for backward compatibility — only IssueID was written
|
|
// before, and only issue-centric tasks ever produced a meta file.
|
|
type GCMeta struct {
|
|
Kind GCMetaKind `json:"kind,omitempty"`
|
|
IssueID string `json:"issue_id,omitempty"`
|
|
ChatSessionID string `json:"chat_session_id,omitempty"`
|
|
AutopilotRunID string `json:"autopilot_run_id,omitempty"`
|
|
TaskID string `json:"task_id,omitempty"`
|
|
WorkspaceID string `json:"workspace_id"`
|
|
CompletedAt time.Time `json:"completed_at"`
|
|
// LocalDirectory marks tasks whose WorkDir pointed at a user-owned
|
|
// path rather than the synthesised envRoot/workdir. The GC loop honours
|
|
// this by never falling into the gcActionClean branch (which would
|
|
// RemoveAll envRoot — safe by structure, but we still want to keep the
|
|
// envRoot's output/ and logs/ around longer so users can inspect what
|
|
// the agent did in their own tree). Pattern-based artifact cleanup is
|
|
// still allowed.
|
|
LocalDirectory bool `json:"local_directory,omitempty"`
|
|
}
|
|
|
|
const gcMetaFile = ".gc_meta.json"
|
|
|
|
// WriteGCMeta writes GC metadata into the given directory. The caller is
|
|
// responsible for choosing Kind and populating the matching ID field;
|
|
// CompletedAt is stamped here so callers don't have to think about clocks.
|
|
func WriteGCMeta(envRoot string, meta GCMeta, logger *slog.Logger) error {
|
|
if envRoot == "" {
|
|
return nil
|
|
}
|
|
if meta.Kind == "" {
|
|
// Defensive: a task that doesn't fit any known kind would write a
|
|
// meta file the GC loop can't dispatch on. Skip silently — the
|
|
// directory falls back to the orphan-by-mtime path.
|
|
logger.Debug("execenv: skipping .gc_meta.json write: kind is empty", "envRoot", envRoot)
|
|
return nil
|
|
}
|
|
meta.CompletedAt = time.Now().UTC()
|
|
data, err := json.Marshal(meta)
|
|
if err != nil {
|
|
return fmt.Errorf("marshal gc meta: %w", err)
|
|
}
|
|
return os.WriteFile(filepath.Join(envRoot, gcMetaFile), data, 0o644)
|
|
}
|
|
|
|
// ReadGCMeta reads GC metadata from a task directory root. Pre-v2 meta files
|
|
// (no kind field) are normalized to GCKindIssue so the legacy issue path
|
|
// keeps working without a migration.
|
|
func ReadGCMeta(envRoot string) (*GCMeta, error) {
|
|
data, err := os.ReadFile(filepath.Join(envRoot, gcMetaFile))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
var meta GCMeta
|
|
if err := json.Unmarshal(data, &meta); err != nil {
|
|
return nil, err
|
|
}
|
|
if meta.Kind == "" {
|
|
meta.Kind = GCKindIssue
|
|
}
|
|
return &meta, nil
|
|
}
|
|
|
|
const managedEnvProvenanceFile = ".managed_env.json"
|
|
|
|
// ManagedEnvProvenanceManagedBy discriminates a managed-env provenance file
|
|
// the daemon wrote from any lookalike JSON that happens to share the path.
|
|
const ManagedEnvProvenanceManagedBy = "multica-daemon-managed-env"
|
|
|
|
// ManagedEnvProvenance is persisted to .managed_env.json inside the env root at
|
|
// Prepare time (NOT on completion, unlike .gc_meta.json). It records that this
|
|
// env root is a daemon-managed, non-local_directory issue env owned by a
|
|
// specific workspace/issue/agent.
|
|
//
|
|
// Its whole reason to exist is timing. A squad-leader follow-up on the same
|
|
// issue can be claimed the instant the prior task completes — the server's
|
|
// task-complete handler reconciles the follow-up and wakes the runtime before
|
|
// the prior task's daemon handler writes .gc_meta.json. Keying reuse
|
|
// eligibility off .gc_meta.json therefore raced: the successor read a
|
|
// not-yet-written file and started a fresh session (MUL-4886). This marker is
|
|
// on disk from the moment the env is created, so the successor can prove reuse
|
|
// safety inside that window. It is written ONLY for non-local managed issue
|
|
// envs, so its presence is itself the "safe to reuse, not a user
|
|
// local_directory" assertion; see shouldReusePriorWorkdir.
|
|
type ManagedEnvProvenance struct {
|
|
ManagedBy string `json:"managed_by"`
|
|
WorkspaceID string `json:"workspace_id"`
|
|
IssueID string `json:"issue_id"`
|
|
AgentID string `json:"agent_id"`
|
|
}
|
|
|
|
// WriteManagedEnvProvenance persists the reuse-eligibility marker at the env
|
|
// root. Callers must only invoke it for non-local_directory issue envs, since
|
|
// the file's presence is the non-local assertion. ManagedBy is stamped here so
|
|
// callers cannot forget the discriminator.
|
|
func WriteManagedEnvProvenance(envRoot string, p ManagedEnvProvenance) error {
|
|
if envRoot == "" {
|
|
return nil
|
|
}
|
|
p.ManagedBy = ManagedEnvProvenanceManagedBy
|
|
data, err := json.Marshal(p)
|
|
if err != nil {
|
|
return fmt.Errorf("marshal managed env provenance: %w", err)
|
|
}
|
|
return os.WriteFile(filepath.Join(envRoot, managedEnvProvenanceFile), data, 0o644)
|
|
}
|
|
|
|
// ReadManagedEnvProvenance reads the Prepare-time reuse-eligibility marker from
|
|
// an env root. A missing or malformed file returns an error; callers fail
|
|
// closed (no reuse) on any error.
|
|
func ReadManagedEnvProvenance(envRoot string) (*ManagedEnvProvenance, error) {
|
|
data, err := os.ReadFile(filepath.Join(envRoot, managedEnvProvenanceFile))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
var p ManagedEnvProvenance
|
|
if err := json.Unmarshal(data, &p); err != nil {
|
|
return nil, err
|
|
}
|
|
return &p, nil
|
|
}
|
|
|
|
// Cleanup tears down the execution environment.
|
|
// If removeAll is true, the entire env root is deleted. Otherwise, workdir is
|
|
// removed but output/ and logs/ are preserved for debugging.
|
|
//
|
|
// For local_directory tasks (env.LocalDirectory==true) WorkDir is the
|
|
// user's own path — Cleanup MUST NEVER delete it, regardless of removeAll.
|
|
// In that mode we only ever delete the envRoot scratch directory.
|
|
func (env *Environment) Cleanup(removeAll bool) error {
|
|
if env == nil {
|
|
return nil
|
|
}
|
|
|
|
if env.LocalDirectory {
|
|
// Never touch the user's directory. RootDir is the daemon's own
|
|
// scratch; safe to remove when the caller asked for a full
|
|
// teardown.
|
|
if removeAll && env.RootDir != "" {
|
|
if err := os.RemoveAll(env.RootDir); err != nil {
|
|
env.logger.Warn("execenv: cleanup local_directory envRoot failed", "error", err)
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
if removeAll {
|
|
if err := os.RemoveAll(env.RootDir); err != nil {
|
|
env.logger.Warn("execenv: cleanup removeAll failed", "error", err)
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Partial cleanup: remove workdir, keep output/ and logs/.
|
|
if err := os.RemoveAll(env.WorkDir); err != nil {
|
|
env.logger.Warn("execenv: cleanup workdir failed", "error", err)
|
|
return err
|
|
}
|
|
return nil
|
|
}
|