mirror of
https://gh-proxy.org/https://github.com/klinsmaya/multica.git
synced 2026-11-11 10:56:45 +08:00
* feat(navigation): unify internal link click semantics (resolver + board/content-link pilots) One shared resolveClickIntent() now defines the click behavior table (plain = in place, cmd = background tab, cmd+shift = foreground tab, middle = background). AppLink consumes it; openLink() threads the intent through multica:navigate so content links in markdown and the editor honor modifiers on all three platform listeners. Content links now navigate in place on plain click (desktop previously forced a new foreground tab). Editor mentions reuse the readonly mention cards instead of a hand-rolled anchor. The "open issue links in new tab" preference is removed (store, settings row, four locales). Co-Authored-By: Claude Fable 5 <[email protected]> * fix(navigation): restore mention click shielding and type the content-link event Review follow-ups: editor mention chips regain the stopPropagation shield the hand-rolled handlers had (parity with the readonly wrappers), and the desktop shell's multica:navigate listener types its event detail like the other two listeners. Co-Authored-By: Claude Fable 5 <[email protected]> * feat(navigation): complete the click-semantics unification across all surfaces Applies the shared click-intent contract everywhere the spec covers: - AppLink: caller onClick now runs before every navigation path and its preventDefault cancels navigation (fixes the sidebar pin drag guard, enables guarded links). - useRowLink and a new useIntentNavigate execute intents for row and callback surfaces; DataTable forwards the mouse event and middle clicks; table view navigates in place with modifier support. - Chat thread rows, inbox rows, search palette results, actor avatars, and editor links (middle click) honor modifiers. - "Open in new tab" added to inbox context menu and every entity row menu (projects, agents, skills, squads, autopilots, runtimes). - ~20 push-on-click buttons converted to AppLink; agent-create back affordances use useBackOrReplace. - Desktop: Cmd+[/], Cmd+arrows, mouse side buttons bound to per-tab history; Windows app-command forwarding; middle click closes tabs. - Web: scroll restoration provider capturing data-tab-scroll-root offsets keyed by pathname, served through the shared pull protocol. - Sub-issues section collapse moved to an in-memory keyed store so it survives in-session back navigation. Co-Authored-By: Claude Fable 5 <[email protected]> * fix(navigation): address review findings on the unification pass - Mouse side buttons: single cross-platform source (renderer mouseup); main process no longer forwards app-command, which double-navigated on Windows/Linux. Bindings hook moved to use-tab-history with tests. - useIntentNavigate requires a NavigationProvider again (no silent test-shaped fallback); inbox tests mount real providers and assert the new modifier-click and context-menu behavior. - Web scroll restoration: writes are suppressed briefly after a memento is served, so clamped restore scrolls can't overwrite or delete it. - Create-issue dialogs keep the modal open when "Customize fields" is modifier-clicked into a background tab. - Entity row menus share one "Open in new tab" shape (adapter call); DataTable click path honors defaultPrevented; ActorAvatar reuses useIntentNavigate instead of a fourth copy of the intent switch. - Search palette: behavioral tests for cmd+click, cmd+Enter, and stale-intent reset; navigation mocks repointed at the context module so the real hooks stay under test. Co-Authored-By: Claude Fable 5 <[email protected]> * fix(navigation): review blockers — tab insertion position and auxclick cell shielding - openTab inserts the new tab immediately right of the opener (the active tab), per MUL-5860 and browser convention, capped at the pinned-first boundary. The explicit "+" button (addTab) still appends; a dedupe hit focuses without reordering. Regression tests cover all four shapes. - Issue table interactive cells (pickers, checkboxes, expand/rename/ create-sub-issue buttons, in-rename capture guard) now stop auxclick the same way they stop click, so middle-clicking a control no longer bubbles into a background-tab row open. Test asserts controls are inert and row dead space still opens. - Cross-workspace open keeping focus-follows is documented at the adapter as a deliberate product exception (MUL-5860): a background tab in a non-visible workspace group would give zero feedback. Co-Authored-By: Claude Fable 5 <[email protected]> --------- Co-authored-by: Claude Fable 5 <[email protected]>
290 lines
11 KiB
TypeScript
290 lines
11 KiB
TypeScript
/**
|
|
* Shared link handling utilities for the editor system.
|
|
*
|
|
* Used by content-editor (ProseMirror click handler), readonly-content
|
|
* (react-markdown link component), and link-hover-card (Open button).
|
|
*/
|
|
|
|
import { isGlobalPath, isReservedSlug } from "@multica/core/paths";
|
|
import { isIssueIdentifier } from "@multica/ui/markdown";
|
|
import type { LinkClickIntent } from "../../navigation/click-intent";
|
|
|
|
/**
|
|
* Top-level workspace-scoped routes. Used to detect "/{route}/..." paths that
|
|
* were authored without a workspace slug — we prepend the current slug so they
|
|
* resolve correctly under the new /{slug}/{route}/... URL shape.
|
|
*
|
|
* Why a hardcoded allowlist: the heuristic must be conservative. A path like
|
|
* "/acme/issues/abc" already has a slug (first segment "acme" isn't a known
|
|
* route), so leaving it alone is correct. A path like "/foo/bar" where "foo"
|
|
* isn't a known route is ambiguous — we don't rewrite it, treating the author
|
|
* as intentional. Only "/issues/..." style paths get auto-prefixed.
|
|
*/
|
|
const WORKSPACE_ROUTE_SEGMENTS = new Set([
|
|
"usage",
|
|
"issues",
|
|
"projects",
|
|
"autopilots",
|
|
"agents",
|
|
"chat",
|
|
"inbox",
|
|
"my-issues",
|
|
"runtimes",
|
|
"skills",
|
|
"settings",
|
|
]);
|
|
|
|
/**
|
|
* Report whether a path is a workspace-scoped app page — `/{slug}/...` where the
|
|
* first segment is a slug a workspace could actually own.
|
|
*
|
|
* The app origin also serves things the app router does not own: `/api/*`,
|
|
* `/uploads/*` (local-storage attachments, proxied by web), `/_next/*`,
|
|
* `/favicon.ico`, and the pre-workspace routes. Every one of those first
|
|
* segments is already a reserved slug, so the reserved list — the same one the
|
|
* backend enforces at workspace creation — answers this question without a
|
|
* parallel deny-list that has to be kept in sync with the backend's routes.
|
|
*/
|
|
function isWorkspaceScopedPath(pathname: string): boolean {
|
|
const first = pathname.split("/")[1] ?? "";
|
|
if (!first) return false;
|
|
let segment: string;
|
|
try {
|
|
segment = decodeURIComponent(first);
|
|
} catch {
|
|
return false;
|
|
}
|
|
return !isReservedSlug(segment.toLowerCase());
|
|
}
|
|
|
|
/**
|
|
* Convert an absolute URL that points at a workspace page on this deployment's
|
|
* own app into the in-app path it addresses; `null` for anything else.
|
|
*
|
|
* An agent or a user pasting `https://<app-host>/acme/issues/123` means the same
|
|
* destination as `/acme/issues/123`. Without this, the URL reads as external and
|
|
* the desktop app hands it to the system browser instead of opening a tab
|
|
* (MUL-5208).
|
|
*
|
|
* `appOrigin` is the deployment's public app URL, which only the platform layer
|
|
* knows (web: the current origin; desktop: the connected environment's app URL).
|
|
* See `useAppOrigin()`.
|
|
*/
|
|
export function toInternalAppPath(
|
|
href: string,
|
|
appOrigin?: string | null,
|
|
): string | null {
|
|
if (!appOrigin) return null;
|
|
let target: URL;
|
|
let app: URL;
|
|
try {
|
|
target = new URL(href);
|
|
app = new URL(appOrigin);
|
|
} catch {
|
|
return null;
|
|
}
|
|
if (target.origin !== app.origin) return null;
|
|
// Opaque origins (file:, data:) compare equal to each other; only real web
|
|
// origins identify the app.
|
|
if (target.protocol !== "http:" && target.protocol !== "https:") return null;
|
|
if (!isWorkspaceScopedPath(target.pathname)) return null;
|
|
return `${target.pathname}${target.search}${target.hash}`;
|
|
}
|
|
|
|
/** An in-app entity page addressed by a link — the two kinds that have a chip. */
|
|
export interface WorkspaceEntityRef {
|
|
kind: "issue" | "project";
|
|
/**
|
|
* Entity id, decoded from the path. A UUID for either kind, or — for an
|
|
* issue only — a bare identifier (`MUL-123`). Callers dispatch on the shape
|
|
* with `isIssueIdentifier`: an identifier still has to be resolved to a real
|
|
* issue before it can be rendered as a chip.
|
|
*/
|
|
id: string;
|
|
/**
|
|
* Workspace slug the link names, or `null` for the slug-less legacy form
|
|
* (`/projects/<uuid>`), which `openLink` resolves against the current
|
|
* workspace. A caller that renders workspace-scoped data MUST compare a
|
|
* non-null slug against the current one — the entity itself is only
|
|
* resolvable inside the workspace that owns it.
|
|
*/
|
|
slug: string | null;
|
|
}
|
|
|
|
const ENTITY_ROUTE_SEGMENTS: Record<string, WorkspaceEntityRef["kind"]> = {
|
|
issues: "issue",
|
|
projects: "project",
|
|
};
|
|
|
|
const UUID_RE =
|
|
/^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$/;
|
|
|
|
/**
|
|
* Does this path segment address one entity of `kind`?
|
|
*
|
|
* A project is only ever addressed by UUID — it has no shorthand. An issue has
|
|
* both, and the identifier form is the one that matters most: `copyLink` and
|
|
* `openInNewTab` both build `paths.issueDetail(identifier || id)`, and the
|
|
* issue route rewrites a UUID URL back to the identifier, so `MUL-123` is what
|
|
* a user actually copies out of the app or the address bar. Accepting only the
|
|
* UUID here would leave the shape people really paste as a raw URL.
|
|
*
|
|
* Identifier-shaped ids are candidates, not hits: the caller resolves one
|
|
* against the current workspace and keeps the plain link when it misses.
|
|
*/
|
|
function isEntityId(kind: WorkspaceEntityRef["kind"], id: string): boolean {
|
|
return UUID_RE.test(id) || (kind === "issue" && isIssueIdentifier(id));
|
|
}
|
|
|
|
function decodeSegment(segment: string): string | null {
|
|
try {
|
|
return decodeURIComponent(segment);
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Stand-in origin for resolving a href that carries no origin of its own. The
|
|
* `.invalid` TLD is reserved as permanently unresolvable (RFC 2606), so no
|
|
* deployment can ever be served from it and no href can use it to pass as one.
|
|
*/
|
|
const RELATIVE_BASE = "https://link.invalid";
|
|
|
|
/**
|
|
* Resolve a link to the path it addresses on THIS deployment; `null` when it
|
|
* addresses anywhere else.
|
|
*
|
|
* Resolving through `URL` rather than testing the string is what makes the
|
|
* answer trustworthy. A leading slash does not mean "this site":
|
|
* `//other.example/x` and `/\other.example/x` both start with one and both name
|
|
* another host, which is where a browser goes. A parser sees the host; a prefix
|
|
* test cannot, and no amount of extra prefixes closes the gap — that is why the
|
|
* shape of this check matters more than the cases it currently rejects.
|
|
*
|
|
* With no `appOrigin` (a platform that cannot report one), only a genuinely
|
|
* relative href resolves: anything carrying a host of its own fails the
|
|
* comparison, which is the safe direction.
|
|
*/
|
|
function toSameOriginPath(
|
|
href: string,
|
|
appOrigin?: string | null,
|
|
): string | null {
|
|
const base = appOrigin || RELATIVE_BASE;
|
|
let target: URL;
|
|
let expected: URL;
|
|
try {
|
|
target = new URL(href, base);
|
|
expected = new URL(base);
|
|
} catch {
|
|
return null;
|
|
}
|
|
// Opaque origins (`javascript:`, `data:`) stringify to "null" and can never
|
|
// equal a real one, so they fall out here too.
|
|
if (target.origin !== expected.origin) return null;
|
|
return `${target.pathname}${target.search}${target.hash}`;
|
|
}
|
|
|
|
/**
|
|
* Parse a link that addresses exactly one issue or project page on this
|
|
* deployment; `null` for everything else — external URLs, list pages, deeper
|
|
* routes, and links carrying a query string or fragment.
|
|
*
|
|
* Accepts a site-relative path and an absolute URL pointing back at this
|
|
* deployment's app origin. Both go through the same origin comparison, so the
|
|
* two forms cannot disagree about what counts as in-app.
|
|
*/
|
|
export function parseWorkspaceEntityLink(
|
|
href: string,
|
|
appOrigin?: string | null,
|
|
): WorkspaceEntityRef | null {
|
|
const path = toSameOriginPath(href, appOrigin);
|
|
if (!path) return null;
|
|
// A query string or fragment addresses something more specific than the
|
|
// entity page (a saved filter, an anchored comment). Collapsing that to a
|
|
// plain entity reference would silently drop it.
|
|
if (path.includes("?") || path.includes("#")) return null;
|
|
|
|
const segments: string[] = [];
|
|
for (const raw of path.split("/").filter(Boolean)) {
|
|
const decoded = decodeSegment(raw);
|
|
if (decoded === null) return null;
|
|
segments.push(decoded);
|
|
}
|
|
|
|
// `/{slug}/{route}/{id}` — what every in-app "copy link" produces.
|
|
// `/{route}/{id}` — slug-less legacy content, current-workspace by
|
|
// definition since `openLink` prepends the current slug to it.
|
|
let slug: string | null;
|
|
let route: string | undefined;
|
|
let id: string | undefined;
|
|
if (segments.length === 3) {
|
|
const [first, second, third] = segments;
|
|
if (!first || isReservedSlug(first.toLowerCase())) return null;
|
|
slug = first;
|
|
route = second;
|
|
id = third;
|
|
} else if (segments.length === 2) {
|
|
slug = null;
|
|
[route, id] = segments;
|
|
} else {
|
|
return null;
|
|
}
|
|
|
|
const kind = route ? ENTITY_ROUTE_SEGMENTS[route] : undefined;
|
|
if (!kind || !id || !isEntityId(kind, id)) return null;
|
|
return { kind, id, slug };
|
|
}
|
|
|
|
/**
|
|
* Open a link — internal paths dispatch multica:navigate, external open new tab.
|
|
*
|
|
* If `currentSlug` is provided and `href` is a workspace-scoped path lacking a
|
|
* slug (e.g. "/issues/abc" instead of "/{slug}/issues/abc"), the slug is
|
|
* prepended. This is for legacy markdown content authored before the URL
|
|
* refactor, or future content where users forget the slug when pasting.
|
|
*
|
|
* `appOrigin` lets absolute URLs pointing back at this deployment take the same
|
|
* internal route as a relative path.
|
|
*
|
|
* `intent` is how the user clicked (see `resolveClickIntent`); the platform
|
|
* listener answering `multica:navigate` executes it — in-place navigation for
|
|
* "push", a new tab otherwise. External links ignore it: they always hand off
|
|
* to the browser / system browser.
|
|
*/
|
|
export function openLink(
|
|
href: string,
|
|
currentSlug?: string | null,
|
|
appOrigin?: string | null,
|
|
intent: LinkClickIntent = "push",
|
|
): void {
|
|
const internalPath = href.startsWith("/")
|
|
? href
|
|
: toInternalAppPath(href, appOrigin);
|
|
if (internalPath) {
|
|
let path = internalPath;
|
|
if (currentSlug && !isGlobalPath(path)) {
|
|
const firstSegment = path.split("/")[1];
|
|
if (firstSegment && WORKSPACE_ROUTE_SEGMENTS.has(firstSegment)) {
|
|
// Path looks like /issues/abc (no slug) — prepend current slug.
|
|
path = `/${currentSlug}${path}`;
|
|
}
|
|
// Otherwise the first segment is either already a slug (e.g. "acme" in
|
|
// "/acme/issues") or something unknown (e.g. "/foo"). Leave it alone —
|
|
// the user wrote what they meant.
|
|
}
|
|
window.dispatchEvent(
|
|
new CustomEvent("multica:navigate", {
|
|
detail: { path, disposition: intent },
|
|
}),
|
|
);
|
|
} else {
|
|
window.open(href, "_blank", "noopener,noreferrer");
|
|
}
|
|
}
|
|
|
|
/** Check if a href is a mention protocol link (should not be opened as a regular link). */
|
|
export function isMentionHref(href: string | null | undefined): href is string {
|
|
return !!href && href.startsWith("mention://");
|
|
}
|